-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renew app icon #1647
Renew app icon #1647
Conversation
Thanks @validblock , there is also Would you mind share the source file? |
Do we really need the menu? The menu does one little thing: Quit the app. Just saying ;)
I saw, the Attached all resources used by me. |
The menu is actually needed to enable desktop notifications, as strange as that sounds. It's a Qt restriction. |
@validblock thanks for the resources. ACK from my side to the new macOS desktop icon, but I guess the Android icon should stay as is. |
I would create a single icon for each OS. No convert scripts from a master icon anymore. |
I try to generate an Android app icon by using the Android Asset Studio. The result is the same icon set as already exists. No difference. Stay this way. |
Regarding to the article Create a macOS Menu Bar Application I would suggest the following tray icon:
Ok? Then I will update the pull request by replacing the trayicon.png. |
I think it makes sense to update the trayicon.
Could you also run also I wanted ping @jadzeidan but forgot, PTAL |
Ack. Change makes sense. LGTM :) |
@validblock do you have time to commit the generated icons too so we could just merge this? |
@benma could you test Android? |
@thisconnect is the icon supposed to change on all platforms? If so, the icons on Android, Windows and Linux have to be compiled as well.
I ran these and this is the output for me: benma@0bac53f After this, on Android it looks like this (DEBUG is new, BitBoxApp is old) On linux: Before: After: Is this good? |
macOS and linux LGTM. I don't like that the logo is so big on Android. CC @jadzeidan WDYT? |
LGTM with nit on Android that the logo is too large compared to the background. Ideally would look more like this: |
I'm not sure how the Android icon is generated. Is the background autogenerated and you just need to provide the correct size logo in the middle? |
@jadzeidan see my comment above https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/android/mkicon.sh so it looks like the original but just resized to various sizes. |
So what's the best fix to make the logo on Android smaller. Provide a smaller logo specifically for Android? |
There is also a "round icon", what a nightmare 😂 |
I'd assume it looks better if there is a bit more whitespace for the android? Alternative: keep as is or change the old one to have a white BG ? |
Yes I think so too.
I don't like the old one because it has a background in a background (below). So I think we should change it so it looks like this: So the question what is the best way to do that? |
@jadzeidan could you make a different icon for android that has 20% white space on each side? so the actual logo takes up about 60% of the image? |
Does this work? |
@thisconnect here is PNG version: |
Any blocker there? |
@validblock sorry the blocker here was me, I was absent for two weeks and need to test the above Android logo. Will do so in the coming days. Sorry that this PR is taking so long 🤯 |
Sorry for the very long delay! @jadzeidan the icon you provided looks good to me: (BitBoxApp DEBUG is new, BitBoxApp is old). Too bad it is not documented anywhere how the round icons were generated :/ @validblock i took the liberty of adding a commit to this PR with the change for Android. @thisconnect anything else missing or is this good to squash and merge? |
LGTM @benma squash and merge! |
Updating app icon according to the [Human Interface Guidelines](https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon)
Thanks very much @validblock and sorry again that this took so long! |
Updating app icon according to the Human Interface Guidelines.